Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with chart histograms #31

Closed
DavidWiseman opened this issue Feb 9, 2022 · 1 comment
Closed

Bug with chart histograms #31

DavidWiseman opened this issue Feb 9, 2022 · 1 comment
Assignees
@DavidWiseman
Labels
defect Something is off and needs to be addressed

Comments

@DavidWiseman
Copy link
Collaborator

Some grids include an optional histogram column. This results in an error:
System.IO.FileNotFoundException: 'Could not load file or assembly 'System.Data.SqlClient, Version=4.6.0.0

This occurs in the call to GetHistogram which uses the following to return a bitmap.
System.Windows.Forms.DataVisualization.Charting

This occurs when chart.DrawToBitMap is called - seems odd to have this dependency.

DBA Dash now uses Microsoft.Data.SqlClient. Including System.Data.SqlClient might be a quick fix but ideally this chart component needs to be replaced with something else.
@DavidWiseman DavidWiseman added the defect Something is off and needs to be addressed label Feb 9, 2022
@DavidWiseman DavidWiseman self-assigned this Feb 9, 2022
@DavidWiseman
Copy link
Collaborator Author

Confirmed that adding System.Data.SqlClient back fixes the issue. Still need to look to see if there is a good replacement.

DavidWiseman added a commit to DavidWiseman/dba-dash that referenced this issue Feb 12, 2022
@DavidWiseman
Histogram column fix
8afcf09 
Fix missing dependency on System.Data.SqlClient.
Fix CPU histogram column width issue in Performance Summary.
trimble-oss#31
@DavidWiseman DavidWiseman mentioned this issue Feb 12, 2022
Merged
DavidWiseman added a commit that referenced this issue Feb 12, 2022
@DavidWiseman
Histogram column fix
ec09dd2 
Fix missing dependency on System.Data.SqlClient.
Fix CPU histogram column width issue in Performance Summary.
#31
@DavidWiseman DavidWiseman mentioned this issue Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidWiseman DavidWiseman

Labels
defect Something is off and needs to be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidWiseman