Skip retry for query timeout #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude query timeout from retry policy. It would be better to use a longer query timeout (configurable). Reduce retry count to 2. trimble-oss#581
For queries without a specific timeout: Increase the timeouts for the hourly collections to 2min and the daily collections to 5min. This will compensate for removing query timeouts from the retry policy. trimble-oss#581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip retry for query timeouts - longer timeouts are a better option in many cases or just wait for the next collection.
Increase default query timeouts for queries that are executed less frequently.
Refactoring.
#581