Config file encryption #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might make it easier to support other encryption options in future.
Add encryption status indication to make it easier to identify if the config file is not encrypted. Displays "Encrypted" or "Not Encrypted". Encrypted is green. Not Encrypted is red if the config file has any persisted passwords otherwise it's orange.
Add option to configure config file backup retention. Backups not created if retention is set to 0. Cleanup runs as part of FolderCleanup as maintenance job only runs for SQL destinations.
Update Json tab title if config file is encrypted. Title is "Json (Decrypted)" to make it clear that we are viewing the config file in it's unencrypted form.
Add config file backup retention configuration via CLI Add tests Simplify confg file cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to encrypt config file
CLI & GUI support for encrypting config
Add option to configure config file backup retention
Update tests. Tests now run in GH action
#615