DBA Dash Upgrades fix for encrypted configs #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure upgrade isn't blocked if another user has a copy of app running. -Force parameter will stop the process without confirmation.
It might not be possible to get the service name from the config file if the config has been encrypted. Add a Stop-Process for DBADashService. We should have a graceful shutdown with Stop-Service but this should ensure it's not running. It might be running as a console app rather than installed as a service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get service name from Get-WmiObject instead of reading the config file. It might not be possible to read the config file if it's encrypted.
Add -Force to Stop-Process. Add a Stop-Process for DBADashService. In most cases Stop-Service should ensure the service isn't running - this won't work if it's run as a console app though.