Allow DBA Dash to work when @@SERVERNAME returns NULL #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve error message that occurs when setting the destination connection if @@ServerName returns a NULL value.
If @@ServerName is NULL, display a warning message. Handle the NULL value and use the computer name as the generated ConnectionID. Using MachineName over ComputerNamePhysicalNetBIOS as it will make sense to use the cluster name for a failover cluster. The user can always override the generated ConnectionID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display a warning that
@@SERVERNAMEis NULL, but allow DBA Dash to work. If generating a ConnectionID, use the value fromSERVERPROPERTY('MachineName')if@@SERVERNAMEis NULL.