Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Innersource Guidelines to better represent Github as well as BitBucket #247

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Updated Innersource Guidelines to better represent Github as well as BitBucket #247

merged 6 commits into from
Jun 1, 2023

Conversation

matthew-dexter-trimble
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lively-rock-075179f10-247.centralus.1.azurestaticapps.net

coliff
coliff reviewed Jun 1, 2023
View reviewed changes
content/innersource/codeowners-configuration.md Outdated
@@ -5,8 +5,9 @@ description: ""
innersource: true
hideToc: true
---
For Github Code Owners is built in. See [About code owners](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners) in the Github documentation for configuration details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a Draft and not ready for review yet, but make sure to use the GitHub capitalization (capital H) everywhere. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lively-rock-075179f10-247.centralus.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lively-rock-075179f10-247.centralus.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lively-rock-075179f10-247.centralus.1.azurestaticapps.net

@matthew-dexter-trimble matthew-dexter-trimble marked this pull request as ready for review June 1, 2023 16:16
@kuhnboy
Copy link
Collaborator

kuhnboy commented Jun 1, 2023

Nice and comprehensvie!

@jeffdoolittle jeffdoolittle merged commit 2b49de8 into main Jun 1, 2023
@jeffdoolittle jeffdoolittle deleted the matthew-update-innersource branch June 1, 2023 19:51
@jeffdoolittle
Copy link
Member

Thanks for making these changes, @matthew-dexter-trimble !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliff coliff coliff left review comments

@jeffdoolittle jeffdoolittle jeffdoolittle approved these changes

@kuhnboy kuhnboy kuhnboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthew-dexter-trimble @kuhnboy @jeffdoolittle @coliff