Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility and Usability Improvements #147

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Feb 21, 2023

  • Many improvements to keyboard controls (switches, dropdown menus)
  • Dark mode for fonts cheat sheet
  • Fix: Skip to Content color improvements for light mode
  • Fix: Angular component search URL now ends with a /
  • Improved: Faster loading Angular components with fetchpriority="high"

- Many improvements to keyboard controls
- Dark mode for fonts cheat sheet
- Skip to Content improvements
- Faster loading Angular components with `fetchpriority="high"`
@coliff coliff linked an issue Feb 21, 2023 that may be closed by this pull request
@msankaran0712
Copy link
Collaborator

does it not have deploy preview ?

@coliff
Copy link
Member Author

coliff commented Feb 21, 2023

does it not have deploy preview ?

unfortunately, not right now. I need to set it up separately to the main deployed site because we don't want changes going to production site until a new release ships... so modus-icons.trimble.com will always show the site as it was on last npm release and deploy previews would show state of the site from main branch.

@coliff coliff marked this pull request as draft February 21, 2023 11:54
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-147.centralus.2.azurestaticapps.net

@coliff coliff marked this pull request as ready for review February 21, 2023 11:59
@trimble-oss trimble-oss deleted a comment from github-actions bot Feb 21, 2023
@trimble-oss trimble-oss deleted a comment from github-actions bot Feb 21, 2023
@coliff coliff merged commit 04cf2b2 into main Feb 21, 2023
@coliff coliff deleted the 144-site-accessibility-issues branch February 21, 2023 16:07
@coliff coliff added documentation Improvements or additions to documentation docs labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Accessibility Issues
2 participants