Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include HTML files in npm package #232

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Don't include HTML files in npm package #232

merged 1 commit into from
Jun 12, 2023

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 9, 2023 •
edited

Description

Don't include HTML files in npm package

  • minor updates to various dev deps

Fixes: #231

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

npm pack --dry-run to confirm .html not included

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff linked an issue Jun 9, 2023 that may be closed by this pull request
npm package includes unneeded HTML files #231
Closed
@coliff
Don't include HTML files in npm package
8ba77fd 
+ minor updates to various dev deps
@coliff coliff force-pushed the 231-npm-package-includes-unneeded-html-files branch from 0d3e3e7 to 8ba77fd Compare June 9, 2023 12:45
@coliff coliff requested a review from msankaran0712 June 9, 2023 12:46
@coliff coliff added the bug Something isn't working label Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-232.centralus.2.azurestaticapps.net

@coliff coliff enabled auto-merge June 9, 2023 12:52
@coliff coliff added this pull request to the merge queue Jun 12, 2023
@coliff coliff removed this pull request from the merge queue due to a manual request Jun 12, 2023
@coliff coliff merged commit f171a26 into main Jun 12, 2023
8 checks passed
@coliff coliff deleted the 231-npm-package-includes-unneeded-html-files branch June 12, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msankaran0712 msankaran0712 msankaran0712 approved these changes

@nspringer-trimble nspringer-trimble Awaiting requested review from nspringer-trimble nspringer-trimble is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm package includes unneeded HTML files
2 participants
@coliff @msankaran0712