Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Transportation icons #237

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 13, 2023

Description

The Envelope, Export, Triangle-Left and Triangle-Right icons in the Transportation set are not used because they exist in Modus-Solid which is used when the icons get built.

Removing them saves a bit of time and keeps the build process a little bit quieter.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Building locally generates the exact same output as these icons were not used at all anyway. No changes are expected as part of this PR.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The Envelope, Export, Triangle-Left and Triangle-Right icons are not used because they exist in Modus-Solid which is used when the icons get built. Removing them saves a bit of time and keeps the build process a little bit quieter.
@coliff coliff requested a review from egunther39 as a code owner June 13, 2023 12:47
@coliff coliff added bug Something isn't working 1 1 story point labels Jun 13, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-237.centralus.2.azurestaticapps.net

@coliff coliff merged commit d24f310 into main Jun 13, 2023
8 checks passed
@coliff coliff deleted the dev/coliff/remove-unused-transportation-icons branch June 13, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 1 story point bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants