Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TSLint Config #241

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Fix TSLint Config #241

merged 1 commit into from
Jun 14, 2023

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 14, 2023

Description

Removed rules which were causing issues. In future any changes made to the JS files must pass linting.

Note: TSLint is deprecated and no longer updated. Final version is v6.1.3.

Fixes: #238

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

ng lint test passes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Removed rules which were causing issues. In future any changes made to the JS files must pass linting.

Note: TSLint is deprecated and no longer updated. Final version is v6.1.3.
@coliff coliff linked an issue Jun 14, 2023 that may be closed by this pull request
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-241.centralus.2.azurestaticapps.net

@coliff coliff merged commit 8226e8d into main Jun 14, 2023
8 checks passed
@coliff coliff deleted the 238-tslint-config-update branch June 14, 2023 10:00
@coliff coliff added bug Something isn't working 1 1 story point labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 1 story point bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSLint Config Update
2 participants