Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions & CODEOWNERS #243

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 15, 2023

Description

  • Add @soniakaukonen as a CODEOWNDER for SVG icons
  • Only run Sonar Scan, Mend Scan and Review Reminders on the 'trimble-oss/modus-icons' repo. (prevents issues with users forking the project and then the Trimble GH Actions failing)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

GitHub Actions Extension for VS Code reports no issues

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

- Add @soniakaukonen as a CODEOWNDER for SVG icons
- Only run Sonar Scan, Mend Scan and Review Reminders on the 'trimble-oss/modus-icons' repo. (prevents issues with forks)
@coliff coliff added bug Something isn't working 1 1 story point labels Jun 15, 2023
@coliff coliff changed the title Update GitHub Actions Update GitHub Actions & CODEOWNERS Jun 15, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-243.centralus.2.azurestaticapps.net

@coliff coliff enabled auto-merge June 20, 2023 06:39
@coliff coliff added this pull request to the merge queue Jun 20, 2023
Merged via the queue into main with commit 5924937 Jun 20, 2023
8 checks passed
@coliff coliff deleted the dev/coliff/github-actions-update branch June 20, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 1 story point bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants