Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier v3 Upgrade #258

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Prettier v3 Upgrade #258

merged 1 commit into from
Jul 14, 2023

Conversation

coliff
Copy link
Member

@coliff coliff commented Jul 11, 2023 •
edited

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff added dependencies dependencies 1 1 story point labels Jul 11, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-258.centralus.2.azurestaticapps.net

@coliff coliff marked this pull request as draft July 12, 2023 06:24
egunther39
egunther39 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@egunther39 egunther39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR

@coliff coliff force-pushed the dev/coliff/prettier-v3-upgrade branch from 6924511 to 940c93b Compare July 14, 2023 15:48
@coliff coliff marked this pull request as ready for review July 14, 2023 15:50
@trimble-oss trimble-oss deleted a comment from github-actions bot Jul 14, 2023
@coliff coliff merged commit 14d7883 into main Jul 14, 2023
8 checks passed
@coliff coliff deleted the dev/coliff/prettier-v3-upgrade branch July 14, 2023 15:53
@trimble-oss trimble-oss deleted a comment from github-actions bot Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egunther39 egunther39 egunther39 approved these changes

@soniakaukonen soniakaukonen Awaiting requested review from soniakaukonen

@nspringer-trimble nspringer-trimble Awaiting requested review from nspringer-trimble nspringer-trimble is a code owner

Assignees
No one assigned
Labels
1 1 story point dependencies dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coliff @egunther39