Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Graph Images for Icon Pages #285

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Aug 23, 2023

Description

Uses PNG images created with capture-website-cli and hosted at: https://github.com/trimble-oss/modus-icons-opengraph

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Locally I can see the image paths are correct.

You can test it by pasting an URL from the deploy preview (e.g. https://ambitious-sky-021d71010-285.centralus.2.azurestaticapps.net/modus-solid/trimble-logo/) in Slack, Google Chat or similar.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Uses PNG images created with `capture-website-cli` and hosted at: https://github.com/trimble-oss/modus-icons-opengraph
@coliff coliff linked an issue Aug 23, 2023 that may be closed by this pull request
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-285.centralus.2.azurestaticapps.net

@coliff
Copy link
Member Author

coliff commented Aug 23, 2023

Works!
image

@coliff coliff merged commit 255e904 into main Aug 23, 2023
8 checks passed
@coliff coliff deleted the 284-add-open-graph-images branch August 23, 2023 07:27
@coliff coliff added documentation Improvements or additions to documentation docs labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Open Graph Images
2 participants