Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS for background-images #294

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Sep 11, 2023

Description

New implementation method: copy and paste the CSS for background-images.

References #293

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Locally with Edge v116

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff changed the title Working CSS encoding Add CSS for background-images Sep 11, 2023
}

addNameSpace(data) {
if (data.indexOf(`http://www.w3.org/2000/svg`) < 0) {

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
http://www.w3.org/2000/svg
' can be anywhere in the URL, and arbitrary hosts may come before or after it.
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-294.centralus.2.azurestaticapps.net

@coliff coliff marked this pull request as draft September 11, 2023 14:58
@coliff coliff force-pushed the dev/nspringer/svg-css-sample branch 2 times, most recently from 919d066 to 3b70a04 Compare September 11, 2023 15:09
@trimble-oss trimble-oss deleted a comment from github-actions bot Sep 11, 2023
@coliff

This comment was marked as resolved.

@trimble-oss trimble-oss deleted a comment from github-actions bot Sep 11, 2023
@coliff coliff marked this pull request as ready for review September 11, 2023 16:03
@trimble-oss trimble-oss deleted a comment from github-actions bot Sep 11, 2023
@nspringer-trimble nspringer-trimble added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit 1f6c331 Sep 11, 2023
7 of 8 checks passed
@nspringer-trimble nspringer-trimble deleted the dev/nspringer/svg-css-sample branch September 11, 2023 16:14
@coliff coliff added the 3 3 story points label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 3 story points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants