Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Material-icon pages from being published #302

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Prevent Material-icon pages from being published #302

merged 1 commit into from
Sep 22, 2023

Conversation

coliff
Copy link
Member

@coliff coliff commented Sep 22, 2023

Description

Fixes: #301

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Locally

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff linked an issue Sep 22, 2023 that may be closed by this pull request
Bug: Non-existent icon pages on site #301
Closed
@coliff coliff added the bug Something isn't working label Sep 22, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-302.centralus.2.azurestaticapps.net

@coliff
Copy link
Member Author

coliff commented Sep 22, 2023

This PR works as expected. The correct number of Solid and Outlined icons is shown (433 - not 434) and the folder icon is not displayed:
https://ambitious-sky-021d71010-302.centralus.2.azurestaticapps.net/modus-outlined/folder/
https://ambitious-sky-021d71010-302.centralus.2.azurestaticapps.net/modus-solid/folder/

@coliff coliff merged commit 6891848 into main Sep 22, 2023
8 checks passed
@coliff coliff deleted the 301-bug-non-existent-icon-pages-on-site branch September 22, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msankaran0712 msankaran0712 msankaran0712 approved these changes

@egunther39 egunther39 Awaiting requested review from egunther39

@nspringer-trimble nspringer-trimble Awaiting requested review from nspringer-trimble nspringer-trimble is a code owner

@soniakaukonen soniakaukonen Awaiting requested review from soniakaukonen

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Non-existent icon pages on site
2 participants
@coliff @msankaran0712