Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site to use Modus Bootstrap v2 CSS #323

Merged
merged 13 commits into from
Oct 30, 2023

Conversation

coliff
Copy link
Member

@coliff coliff commented Oct 26, 2023

Description

This PR updates the CSS to use Modus Bootstrap v2. It was relatively straightforward by using: https://github.com/coliff/bootstrap-5-migrate-tool and spending about 2 hours tweaking a few things.

The migration should be mostly unnoticeable to the end-user of the site... but the CSS is a lot smaller (faster to load) as it doesn't require a separate stylesheet for dark mode.

Preview: https://ambitious-sky-021d71010-323.centralus.2.azurestaticapps.net

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Locally with Edge v118

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff linked an issue Oct 26, 2023 that may be closed by this pull request
@coliff
Copy link
Member Author

coliff commented Oct 26, 2023

Light mode (icon):
image

Dark mode (icon):
image

Light mode (icon set):
image

Dark mode (icon set):
image

@coliff coliff changed the title Update site to use Modus Bootstrap v2 Update site to use Modus Bootstrap v2 CSS Oct 26, 2023
@coliff coliff force-pushed the 297-docs-upgrade-site-to-modus-bootstrap-v2 branch from d1ae1a1 to 8f60c03 Compare October 26, 2023 11:32
@trimble-oss trimble-oss deleted a comment from github-actions bot Oct 26, 2023
@coliff coliff force-pushed the 297-docs-upgrade-site-to-modus-bootstrap-v2 branch from dd186a4 to 1c3dcd4 Compare October 26, 2023 12:08
Copy link
Collaborator

@egunther39 egunther39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I shared in chat, please double check the icon alignments in the icon detail page examples. Some seems off.

The menu in the nav bar is not displaying correctly
image

Copy link
Collaborator

@msankaran0712 msankaran0712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why this gap? I see the same on old site too.

image

Copy link
Collaborator

@msankaran0712 msankaran0712 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different font size and color for both the dark and light theme
image

Copy link
Member Author

@coliff coliff Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Modus Bootstrap v2 has responsive-font-sizes so the size scales down depending on the screen size, but never appearing bigger than before and always sized proportionally. Responsive font sizes are great because without it the larger heading sizes often require wrapping to multiple lines on small screens. The Modus Icons header there is using display-2 which is: font-size: calc(1.375rem + 1.5vw);

  • In light mode the header is Trimble Blue #0063a3 and in dark mode it now uses dark mode Trimble blue #019aeb:
    https://modus.trimble.com/foundations/color-palette/#special-case-colors

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coliff I think the title color is not changing in dark mode, it is always #0063a3.

@coliff coliff force-pushed the 297-docs-upgrade-site-to-modus-bootstrap-v2 branch 2 times, most recently from 3637cb6 to e7e62ca Compare October 27, 2023 08:03
@trimble-oss trimble-oss deleted a comment from github-actions bot Oct 27, 2023
@coliff coliff merged commit 5c5f145 into main Oct 30, 2023
7 of 8 checks passed
@coliff coliff deleted the 297-docs-upgrade-site-to-modus-bootstrap-v2 branch October 30, 2023 13:09
@soniakaukonen
Copy link

@coliff

The icon only button example (without outline) does not show states when hovered over.
When clicked, an outline appears.

Navbar example appears massive.

@coliff coliff added documentation Improvements or additions to documentation docs labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: upgrade site to Modus Bootstrap v2
4 participants