-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update site to use Modus Bootstrap v2 CSS #323
Conversation
d1ae1a1
to
8f60c03
Compare
dd186a4
to
1c3dcd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why this gap? I see the same on old site too.
- For
Modus on GitHub
link, can we redirect it to the list of public repositories filtered by Modus keyword - UI issues
Show Categories
radio button animation is not smooth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Modus Bootstrap v2 has responsive-font-sizes so the size scales down depending on the screen size, but never appearing bigger than before and always sized proportionally. Responsive font sizes are great because without it the larger heading sizes often require wrapping to multiple lines on small screens. The Modus Icons header there is using display-2 which is:
font-size: calc(1.375rem + 1.5vw);
-
In light mode the header is Trimble Blue
#0063a3
and in dark mode it now uses dark mode Trimble blue#019aeb
:
https://modus.trimble.com/foundations/color-palette/#special-case-colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coliff I think the title color is not changing in dark mode, it is always #0063a3
.
3637cb6
to
e7e62ca
Compare
…/github.com/trimble-oss/modus-icons into 297-docs-upgrade-site-to-modus-bootstrap-v2
The icon only button example (without outline) does not show states when hovered over. Navbar example appears massive. |
Description
This PR updates the CSS to use Modus Bootstrap v2. It was relatively straightforward by using: https://github.com/coliff/bootstrap-5-migrate-tool and spending about 2 hours tweaking a few things.
The migration should be mostly unnoticeable to the end-user of the site... but the CSS is a lot smaller (faster to load) as it doesn't require a separate stylesheet for dark mode.
Preview: https://ambitious-sky-021d71010-323.centralus.2.azurestaticapps.net
Type of change
How Has This Been Tested?
Locally with Edge v118
Checklist