Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Search to Navbar #326

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Move Search to Navbar #326

merged 1 commit into from
Oct 31, 2023

Conversation

coliff
Copy link
Member

@coliff coliff commented Oct 31, 2023

Description

Part 1 of switching the Search input to match the new style guide

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link
Collaborator

@egunther39 egunther39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use default search bar height and make width 256px. Thanks!

Copy link

@soniakaukonen soniakaukonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navbar looks good, but when it comes to other behaviors: hover of danger icon button makes it darker whereas our hover state is lighter than default @coliff .

@coliff
Copy link
Member Author

coliff commented Oct 31, 2023

Navbar looks good, but when it comes to other behaviors: hover of danger icon button makes it darker whereas our hover state is lighter than default @coliff .

Thanks - that's helpful feedback. I'll fix that in Modus Bootstrap v2 which mean it'll be fixed on here and Style guide v2 in the next alpha release.

@coliff coliff force-pushed the dev/coliff/move-search-to-navbar branch from 911816b to 456cc6b Compare October 31, 2023 14:36
Part 1 of switching the Search input to match the new styleguide
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-sky-021d71010-326.centralus.2.azurestaticapps.net

@coliff coliff merged commit c883db9 into main Oct 31, 2023
14 checks passed
@coliff coliff deleted the dev/coliff/move-search-to-navbar branch October 31, 2023 15:19
@coliff coliff added documentation Improvements or additions to documentation 2 2 story points docs labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 2 story points docs documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants