Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar add additional App #1638

Closed
2 tasks done
jmecosta opened this issue Aug 14, 2023 · 15 comments
Closed
2 tasks done

Navbar add additional App #1638

jmecosta opened this issue Aug 14, 2023 · 15 comments
Labels
external-request Bugs and features reported by individuals from other teams in Trimble modus-approved Reviewed and approved by Modus team-trimble-desktop-tekla Trimble Desktop from Tekla team

Comments

@jmecosta
Copy link

Prerequisites

Proposal

Hi,

Looks i cant configure the Navbar to add App in front on Trimble.

image

This is quite common for Trimble Applications. the avatar, i think its currently under proposal so would be nice to get it as soon as possible.

Thanks

Motivation and context

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

High

What product/project are you using Modus Components for ?

Trimble Desktop

What is your team/division name ?

Tekla Team

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Aug 14, 2023
@msankaran0712 msankaran0712 added the team-trimble-desktop-tekla Trimble Desktop from Tekla team label Aug 22, 2023
@msankaran0712
Copy link
Contributor

@jmecosta Thank you for submitting the issue. Kindly let us know if your team is interested in fixing the issue.

@jmecosta
Copy link
Author

@msankaran0712 yes we can contribute

@msankaran0712
Copy link
Contributor

Thank you @jmecosta

@msankaran0712
Copy link
Contributor

@jmecosta Can you please confirm what is that App ? is it a logo or a button that can be interacted with?

@jmecosta
Copy link
Author

jmecosta commented Aug 23, 2023 via email

@msankaran0712
Copy link
Contributor

@egunther39 Is that okay to hide profile menu icon?

@msankaran0712
Copy link
Contributor

@soniakaukonen to check with TID team

@msankaran0712
Copy link
Contributor

@jmecosta It is okay to hide the profile icon if no TID implementation.

@jmecosta
Copy link
Author

Sure this case the app is not integrated with tid.

@msankaran0712 msankaran0712 added the modus-approved Reviewed and approved by Modus label Sep 13, 2023
@msankaran0712
Copy link
Contributor

@jmecosta the issue is approved and ready to be worked on

@soniakaukonen
Copy link

issued for style guide trimble-oss/website-modus.trimble.com#714

@msankaran0712
Copy link
Contributor

@enowak1031 to check with Branding team whether it is okay to display "Trimble Logo | Product Logo | Application Logo "

@msankaran0712
Copy link
Contributor

@jmecosta A separate issue has been created for making the profile menu optional, #1782
Anybody who is interested can contribute a PR 👍🏼

@msankaran0712
Copy link
Contributor

msankaran0712 commented Nov 8, 2023

@jmecosta Only one logo is allowed in the navbar

@cjwinsor
Copy link
Contributor

cjwinsor commented Apr 5, 2024

@jmecosta The profile menu is now optional. Use the showProfile property set to false to hide. With the logo, the current guidance is to have a combined logo following the branding guidance. Due to this, I will be closing this ticket.

@cjwinsor cjwinsor closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble modus-approved Reviewed and approved by Modus team-trimble-desktop-tekla Trimble Desktop from Tekla team
Projects
Status: Done
Development

No branches or pull requests

4 participants