Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Component: Set and emit value by object ref instead of display prop #1644

Merged

Conversation

ryan-henness-trimble
Copy link
Contributor

@ryan-henness-trimble ryan-henness-trimble commented Aug 16, 2023

Description

This fixes an issue where the setter and emitter for the current value was using the object's display property rather than the object itself.

Closes #1643

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How Has This Been Tested?

Manually installing into our project, and e2e tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ryan-henness-trimble ryan-henness-trimble requested a review from a team as a code owner August 16, 2023 17:05
@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit 7d4134f
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/64dd01bdb2e201000895f6ad
😎 Deploy Preview https://deploy-preview-1644--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff merged commit fdd4367 into trimble-oss:main Aug 17, 2023
10 checks passed
@msankaran0712 msankaran0712 added the breaking-change Changes that can potentially impact the applications already using it label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that can potentially impact the applications already using it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select component using display as the component's value rather than the object passed in
3 participants