Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default padding for dropdown menus in Modus Navbar component #1670

Merged

Conversation

msankaran0712
Copy link
Contributor

@msankaran0712 msankaran0712 commented Aug 25, 2023

Fixes #1669

Preview:
Press Add icon in https://icy-ground-0374a1310-1670.centralus.1.azurestaticapps.net/?path=/docs/components-navbar--default and notice the padding for the dropdown

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Press Add icon in https://icy-ground-0374a1310-1670.centralus.1.azurestaticapps.net/?path=/docs/components-navbar--default

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@msankaran0712 msankaran0712 requested review from coliff and a team as code owners August 25, 2023 06:56
@msankaran0712 msankaran0712 added bug Something is wrong and needs to be addressed breaking-change Changes that can potentially impact the applications already using it labels Aug 25, 2023
@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit 6cec0f6
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/64f1b68a8897620008600a75
😎 Deploy Preview https://deploy-preview-1670--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@msankaran0712 msankaran0712 marked this pull request as draft August 25, 2023 06:59
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-ground-0374a1310-1670.centralus.1.azurestaticapps.net

@msankaran0712 msankaran0712 marked this pull request as ready for review September 1, 2023 10:01
@msankaran0712 msankaran0712 force-pushed the issue-1669-fix-navbar-dropdown-menu-default-padding branch from 060761d to 6cec0f6 Compare September 1, 2023 10:01
@trimble-oss trimble-oss deleted a comment from github-actions bot Sep 1, 2023
@msankaran0712 msankaran0712 merged commit 2e84681 into main Sep 1, 2023
12 checks passed
@msankaran0712 msankaran0712 deleted the issue-1669-fix-navbar-dropdown-menu-default-padding branch September 1, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that can potentially impact the applications already using it bug Something is wrong and needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modus Navbar : Custom Dropdown Menu default padding should be removed
2 participants