Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created Modus Icon component and added icons for expand all and collapse all #1673

Merged
merged 11 commits into from
Sep 7, 2023
Merged

Created Modus Icon component and added icons for expand all and collapse all #1673

merged 11 commits into from
Sep 7, 2023

Conversation

rjavier-trimbler
Copy link
Contributor

@rjavier-trimbler rjavier-trimbler commented Aug 28, 2023 •
edited by msankaran0712
Loading

Description

  • expand all icon added (chevron double up icon)
  • collapse all icon added (chevron double down icon)
  • icons storybook section included to see all icons available

References #
https://e-builderinc.atlassian.net/browse/NAV-227

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@rjavier-trimbler rjavier-trimbler requested a review from a team as a code owner August 28, 2023 15:32
@netlify
Copy link

netlify bot commented Aug 28, 2023 •
edited
Loading

✅ Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit 3d4097f
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/64f8ba52448c0600080bfa1c
😎 Deploy Preview https://deploy-preview-1673--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 26 (🔴 down 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

bradley-eb
bradley-eb approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@bradley-eb bradley-eb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you should get approval from owners of the modus-web-components before merging.

msankaran0712
msankaran0712 suggested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@msankaran0712 msankaran0712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjavier-trimbler, For every pull request, please ensure it is associated with a GitHub issue. Could you kindly create the issue and provide a link?

@jkendell89
Copy link

References #1098

msankaran0712
msankaran0712 suggested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@msankaran0712 msankaran0712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjavier-trimbler @jkendell89 Your contribution is greatly appreciated! Thank you. I have added comments, and please let me know if you have any questions.

stencil-workspace/storybook/stories/components/modus-icons/modus-icons.stories.tsx Show resolved Hide resolved
stencil-workspace/src/components/modus-icons/modus-icons.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/modus-icons/modus-icons.tsx Show resolved Hide resolved
stencil-workspace/src/components/icons/icon-chevron-double-down.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/modus-icons/modus-icons.tsx Outdated Show resolved Hide resolved
stencil-workspace/storybook/stories/components/modus-icons/modus-icons-storybook-docs.mdx Outdated Show resolved Hide resolved
stencil-workspace/storybook/stories/components/modus-icons/modus-icons-storybook-docs.mdx Show resolved Hide resolved
@msankaran0712
Copy link
Contributor

@rjavier-trimbler @jkendell89 Could you please create a new GitHub issue? Modus needs more details for this issue for tracking purposes, and the existing Issue #1098 is a bigger story that might not be appropriate.

@msankaran0712
Copy link
Contributor

@rjavier-trimbler Thank you for fixing other icons like the calendar icon. A couple of comments are pending.

msankaran0712
msankaran0712 suggested changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@msankaran0712 msankaran0712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whichever icon is updated, kindly make sure the default colour as currentcolor not the hex code.

stencil-workspace/src/components/icons/icon-calendar.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/icons/icon-cancel.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/icons/icon-chevron-double-down.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/icons/icon-chevron-double-up.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/icons/icon-chevron-down-thick.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/icons/icon-chevron-up-thick.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/icons/icon-collapse-all.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/icons/icon-copy.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/icons/icon-delete.tsx Outdated Show resolved Hide resolved
stencil-workspace/src/components/modus-icons/modus-icons.tsx Outdated
@Prop() size?: string = '16';

/** (optional) The color of the Icon */
@Prop() color?: string = '#6A6976';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not have a default hex code for now. Instead, please update each of the above icons to use the default as currentcolor for fill

@msankaran0712 msankaran0712 changed the title add icons for the expand all and collapse all links. Created Modus Icon component and added icons for expand all and collapse all Sep 7, 2023
@coliff coliff merged commit f4faf49 into trimble-oss:main Sep 7, 2023
11 checks passed
@coliff
Copy link
Member

coliff commented Sep 7, 2023

Great PR - thanks for the contribution!

@msankaran0712
Copy link
Contributor

Linking this PR to an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliff coliff coliff approved these changes

@msankaran0712 msankaran0712 msankaran0712 approved these changes

@bradley-eb bradley-eb bradley-eb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rjavier-trimbler @jkendell89 @msankaran0712 @coliff @bradley-eb