-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
date picker year aria labels reversed and year selection icons both have down arrow classes #1721
date picker year aria labels reversed and year selection icons both have down arrow classes #1721
Conversation
✅ Deploy Preview for modus-webcomponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@acomsto It's looking good to me. I will give @coliff and @msankaran0712 a chance to take a look |
I think that change is very welcome. The icon tap-target was far too small before (12px x 12px) and now it is 16px x 16px. |
@coliff My only concern was in Figma, the space is less |
|
||
button:first-child { | ||
transform: rotate(180deg) scaleX(-1); | ||
button { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this margin so that there enough space between the icons and no accessibility issue
cc @coliff
Description
caret-up
icon toIconMap.tsx
References #1718
Type of change
How Has This Been Tested?
Ran all tests
Checklist