Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date picker year aria labels reversed and year selection icons both have down arrow classes #1721

Conversation

acomsto
Copy link
Contributor

@acomsto acomsto commented Sep 13, 2023

Description

  • Fix issue where date picker aria labels are reversed, "Next Year" now corresponds to up, and "Previous Year" now corresponds with down
  • Fix issue where both year selection icons had the same class name icon-triangle-down, these icons are now caret-up and caret-down
  • Add caret-up icon to IconMap.tsx
  • Fix styling to now account for caret icons instead of the arrow icons

References #1718

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Ran all tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@acomsto acomsto requested review from coliff and a team as code owners September 13, 2023 18:03
@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit 14b0d21
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/6509ce8dd0bf3f0008c38569
😎 Deploy Preview https://deploy-preview-1721--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ryan-henness-trimble
Copy link
Contributor

ryan-henness-trimble commented Sep 13, 2023

@acomsto It's looking good to me. I will give @coliff and @msankaran0712 a chance to take a look

msankaran0712

This comment was marked as resolved.

@coliff
Copy link
Member

coliff commented Sep 14, 2023

There seems to be more space between the caret-up and caret-down icons now

I think that change is very welcome. The icon tap-target was far too small before (12px x 12px) and now it is 16px x 16px.

@msankaran0712
Copy link
Contributor

msankaran0712 commented Sep 14, 2023

There seems to be more space between the caret-up and caret-down icons now

I think that change is very welcome. The icon tap-target was far too small before (12px x 12px) and now it is 16px x 16px.

@coliff My only concern was in Figma, the space is less

msankaran0712
msankaran0712 previously approved these changes Sep 19, 2023

button:first-child {
transform: rotate(180deg) scaleX(-1);
button {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this margin so that there enough space between the icons and no accessibility issue
cc @coliff

coliff
coliff previously approved these changes Sep 19, 2023
@acomsto acomsto dismissed stale reviews from coliff and msankaran0712 via 0cc2a2f September 19, 2023 16:37
@msankaran0712 msankaran0712 merged commit a1a623b into trimble-oss:main Sep 20, 2023
10 checks passed
@coliff coliff added the bug Something is wrong and needs to be addressed label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants