Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Inline editing for Table component #1737

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

msankaran0712
Copy link
Contributor

@msankaran0712 msankaran0712 commented Sep 28, 2023

  1. Added Inline Editing capability for Modus Table component.
  2. Added support for CSS parts in all the Form controls like text input, number input, select and date. This helps us in removing the blue bottom line for the controls.
  3. Included events for most of the user actions that include,
    • Sorting
    • Pagination
    • Column Resize
    • Column Reorder
    • Column Visibility change
    • Row Selection
    • Row Expand/Collapse
    • Cell value change
    • Cell Link click
  4. I made some changes to the code so that the component is now managed in several smaller pieces.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Storybook page - https://deploy-preview-1737--modus-webcomponents.netlify.app/?path=/story/components-table--large-dataset

Click on any cell(except the cells having a link) to edit the cell value through a text/number input. Note: The dropdown cell editor also works, check out the column with the header text "Status". For a dropdown cell editor, the Enter key does not move away from the cell as it does on text/number inputs, because of the limitations of HTML Select control.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@msankaran0712 msankaran0712 requested review from coliff and a team as code owners September 28, 2023 11:38
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit d2b5f2a
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/65251df361b1560008052ba0
😎 Deploy Preview https://deploy-preview-1737--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@msankaran0712 msankaran0712 marked this pull request as draft September 28, 2023 11:39
@msankaran0712 msankaran0712 force-pushed the dev/msankaran/modus-table-inline-editing branch 2 times, most recently from dd5bead to f0be63c Compare October 9, 2023 10:39
@msankaran0712 msankaran0712 marked this pull request as ready for review October 9, 2023 11:17
@msankaran0712 msankaran0712 force-pushed the dev/msankaran/modus-table-inline-editing branch from f0be63c to 8af1db2 Compare October 9, 2023 11:19
coliff
coliff previously approved these changes Oct 9, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-ground-0374a1310-1737.centralus.1.azurestaticapps.net

@msankaran0712 msankaran0712 merged commit ccd0d6f into main Oct 11, 2023
13 checks passed
@msankaran0712 msankaran0712 deleted the dev/msankaran/modus-table-inline-editing branch October 11, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants