Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Upload Dropzone Accessibility Fixes #1759

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

coliff
Copy link
Member

@coliff coliff commented Oct 4, 2023

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Edge v117

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff requested a review from a team as a code owner October 4, 2023 15:33
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit ef2b961
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/651fa9b4e1416a0008247648
😎 Deploy Preview https://deploy-preview-1759--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff added 1 1 story point accessibility labels Oct 4, 2023
@coliff coliff marked this pull request as draft October 4, 2023 15:37
@coliff coliff force-pushed the dev/coliff/file-upload-a11y-fixes branch from daf08f9 to 6b20582 Compare October 4, 2023 15:49
@coliff coliff marked this pull request as ready for review October 4, 2023 15:54
Copy link
Contributor

@msankaran0712 msankaran0712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something minor, the icon does not look to be centered
image

@coliff
Copy link
Member Author

coliff commented Oct 5, 2023

thanks for spotting that. That was an error on my part, the updated SVG I added should have viewport 24 x 24, not 32x32 as it was before. Fixed now locally and committing

@coliff coliff force-pushed the dev/coliff/file-upload-a11y-fixes branch from 20bbc68 to d89e283 Compare October 5, 2023 07:20
@coliff coliff enabled auto-merge (squash) October 5, 2023 07:40
@msankaran0712 msankaran0712 force-pushed the dev/coliff/file-upload-a11y-fixes branch from d89e283 to 6719258 Compare October 6, 2023 06:05
@msankaran0712 msankaran0712 force-pushed the dev/coliff/file-upload-a11y-fixes branch from 6719258 to ef2b961 Compare October 6, 2023 06:31
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-ground-0374a1310-1759.centralus.1.azurestaticapps.net

@coliff coliff merged commit a85ab7b into main Oct 6, 2023
11 checks passed
@coliff coliff deleted the dev/coliff/file-upload-a11y-fixes branch October 6, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 1 story point accessibility
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants