Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom footer slot for Modal component #1786

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

pchaudh18
Copy link
Contributor

@pchaudh18 pchaudh18 commented Oct 17, 2023

Description

References #1728

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@pchaudh18 pchaudh18 requested a review from a team as a code owner October 17, 2023 15:19
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit f672c86
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/653129d98e43280008d3594a
😎 Deploy Preview https://deploy-preview-1786--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@msankaran0712
Copy link
Contributor

@palakchaudhary18 I have modified the code to fix some issues. Kindly use the exact code from the attachment
ModusModal.zip

@msankaran0712 msankaran0712 changed the title Issue 1728/third button Add custom footer slot for Modal component Oct 18, 2023
Copy link
Contributor

@msankaran0712 msankaran0712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the attachment files for the latest code

@pchaudh18 pchaudh18 closed this Oct 18, 2023
@pchaudh18 pchaudh18 reopened this Oct 18, 2023
@pchaudh18
Copy link
Contributor Author

Hi
I have updated the branch with new changes for the modus-modal and some auto-updated files

msankaran0712
msankaran0712 previously approved these changes Oct 19, 2023
@msankaran0712 msankaran0712 merged commit e96b5a1 into trimble-oss:main Oct 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants