Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the non-accessible hyperlink cell content in Modus Table #1812

Merged

Conversation

msankaran0712
Copy link
Contributor

@msankaran0712 msankaran0712 commented Oct 19, 2023

References #1811

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

https://deploy-preview-1812--modus-webcomponents.netlify.app/?path=/story/components-table--hyperlink
Navigate to any of the row cell with hyperlink using the Tab key and focus the hyperlink inside the cell and press Enter key to trigger cell link click event visible under Actions tab

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@msankaran0712 msankaran0712 requested review from coliff and a team as code owners October 19, 2023 09:52
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit 6e14b6d
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/65311079ce52e00008cea3d1
😎 Deploy Preview https://deploy-preview-1812--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@msankaran0712 msankaran0712 added the bug Something is wrong and needs to be addressed label Oct 19, 2023
@msankaran0712 msankaran0712 force-pushed the issue-1811-fix-table-hyperlink-cell-not-accessible branch from cf5ccee to 3b7034d Compare October 19, 2023 11:06
coliff
coliff previously approved these changes Oct 19, 2023
@msankaran0712 msankaran0712 force-pushed the issue-1811-fix-table-hyperlink-cell-not-accessible branch from 3b7034d to 6e14b6d Compare October 19, 2023 11:18
@msankaran0712 msankaran0712 requested a review from a team October 19, 2023 11:18
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-ground-0374a1310-1812.centralus.1.azurestaticapps.net

@msankaran0712 msankaran0712 merged commit ffcae7f into main Oct 20, 2023
11 checks passed
@msankaran0712 msankaran0712 deleted the issue-1811-fix-table-hyperlink-cell-not-accessible branch October 20, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants