Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Footer honors density property #2124

Merged
merged 24 commits into from
Apr 2, 2024

Conversation

ElishaSamPeterPrabhu
Copy link
Collaborator

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu commented Feb 7, 2024

Description

  • Based on density property value the header and footer height is modified along with the padding values of the header and footer cell.

References
#1969

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

https://deploy-preview-2124--moduswebcomponents.netlify.app/

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit fc2f1b5
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/660c83d6d933d500081fa7fa
😎 Deploy Preview https://deploy-preview-2124--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu changed the title Issue 1969/table footer honors denisty property Table : Footer honors density property Feb 7, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu changed the title Table : Footer honors density property Table: Footer honors density property Feb 7, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu force-pushed the issue-1969/table-footer-honors-denisty-property branch from 39f3b29 to 4b7b0ca Compare February 7, 2024 09:44
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu marked this pull request as draft February 7, 2024 10:07
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu force-pushed the issue-1969/table-footer-honors-denisty-property branch from 4b7b0ca to 1bb1cd2 Compare February 8, 2024 05:51
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu marked this pull request as ready for review February 8, 2024 05:58
@cjwinsor cjwinsor added the modus-table Modus Table component development label Mar 14, 2024
cjwinsor
cjwinsor previously approved these changes Apr 2, 2024
@cjwinsor cjwinsor merged commit a01708b into main Apr 2, 2024
8 checks passed
@cjwinsor cjwinsor deleted the issue-1969/table-footer-honors-denisty-property branch April 2, 2024 22:34
austinoneil pushed a commit to austinoneil/modus-web-components that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modus-table Modus Table component development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants