-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table: Fix linting warning resulting from using any
type
#2338
Conversation
✅ Deploy Preview for moduswebcomponents ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
An alternate approach would be to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM - confirmed lint error is gone with this PR.
@austinoneil I'll check on the use of |
@austinoneil For this one, when running
I am good with the update just being to set it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to use unknown
instead of any
. Using an interface on this EventEmitter breaks our Angular builds for some reason.
@cjwinsor done |
any
typeany
type
Description
Updated type emitted from an event to be more strongly typed, avoiding the lint error from using the
any
type.Type of change
How Has This Been Tested?
Checklist