-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input: Add autocapitalize
, autocorrect
, enterkeyhint
, and spellcheck
properties
#2351
Conversation
✅ Deploy Preview for moduswebcomponents ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
autocapitalize
, autocorrect
, enterkeyhint
, and spellcheck
properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! looks good.. but we need to have the additional controls to the demo canvas:
https://deploy-preview-2351--moduswebcomponents.netlify.app/?path=/story/user-inputs-text-input--default
(autocapitalize
, autocorrect
, enterkeyhint
, and spellcheck
options should be available here)
I don't think we need demos of them on the Docs page, can you please remove?
@coliff done. |
Oops. Fixed. |
thanks for work on this so far - still a few more things:
|
I made the changes (except for spellcheck, as that is an attribute that is |
7c033c4
to
caf0487
Compare
caf0487
to
dabd3dd
Compare
…lcheck `properties (trimble-oss#2351) * Add autocapitalize, autocorrect, enterkeyhing, and spellcheck properties to input * Update modus-text-input-storybook-docs.mdx --------- Co-authored-by: Austin O'Neil <austinoneil@Austins-MacBook-Pro-2.local> Co-authored-by: coliff <christianoliff@pm.me>
@austinoneil Why make autocorrect: boolean | 'off' | 'on'; Why not stick to just an enumeration or just a boolean? |
@kuhnboy When I as a developer see |
* Add `modus-textarea-input` component. * add autocorrect, autocapitalize, enterkeyhing, spellcheck to textarea reflecting #2351 * add documentation * fix merge conflicts (I think) * removed resizability for textarea * remove angular changes from pull request * Update package.json * Delete angular-workspace/ng14/projects/trimble-oss/modus-angular-components/src/lib/stencil-generated/angular-component-lib/utils.ts * Delete angular-workspace/ng14/package-lock.json * manually removed angular autogenerated stuff * manually removed react autogenerated files * add ng14 lock back * revert icon readme chages --------- Co-authored-by: Austin O'Neil <austinoneil@Austins-MacBook-Pro-2.local> Co-authored-by: Christian Oliff <christianoliff@pm.me>
Description
Add autocapitalize, autocorrect, enterkeyhint, and spellcheck properties to input
References #2347
Type of change
How Has This Been Tested?
Added unit tests
Checklist