Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Fix issue where enter, escape, and space key are not having desired output #2396

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

austinoneil
Copy link
Contributor

@austinoneil austinoneil commented Apr 3, 2024

Description

  • Delete excessive calls to methods that react to input
  • Update tests to better reflect a user journey, replacing existing unit tests with more black-box e2e tests.

References #2392

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

E2E tests, manually using the following code in index.html:

    <modus-dropdown toggle-element-id="toggleElement">
      <modus-button id="toggleElement" slot="dropdownToggle" show-caret="true">Dropdown</modus-button>
      <modus-list slot="dropdownList">
        <modus-list-item size="condensed" borderless>Item 1</modus-list-item>
        <modus-list-item size="condensed" borderless>Item 2</modus-list-item>
        <modus-list-item size="condensed" borderless>Item 3</modus-list-item>
      </modus-list>
    </modus-dropdown>
    <modus-text-input></modus-text-input>

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 319f34f
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/660da2b12ea5010009016fb1
😎 Deploy Preview https://deploy-preview-2396--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff requested a review from cjwinsor April 4, 2024 01:35
@coliff coliff added the bug Something is wrong and needs to be addressed label Apr 4, 2024
@cjwinsor cjwinsor merged commit c7b98ae into trimble-oss:main Apr 4, 2024
8 checks passed
austinoneil added a commit to austinoneil/modus-web-components that referenced this pull request Apr 4, 2024
… desired output (trimble-oss#2396)

* Fix opening dropdown with space and enter

* delete unused code, replace unit tests with end-to-end tests

---------

Co-authored-by: Austin O'Neil <austinoneil@Austins-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants