Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion: Style Fixes #2407

Conversation

coliff
Copy link
Member

@coliff coliff commented Apr 4, 2024

Description

  • Correct horizontal padding (16px - was 8px)
  • Correct Chevron Rotation

Fixes: #2405

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

https://deploy-preview-2407--moduswebcomponents.netlify.app/?path=/story/components-accordion--default

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

- Correct horizontal padding (16px - was 8px)
- Expanded state header background color
@coliff coliff linked an issue Apr 4, 2024 that may be closed by this pull request
@coliff coliff requested a review from cjwinsor April 4, 2024 12:45
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 13d60ae
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/6617db7696652b000877b8d0
😎 Deploy Preview https://deploy-preview-2407--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff requested a review from egunther39 April 8, 2024 12:00
Copy link

@egunther39 egunther39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the circle icon change color to blue-light when expanded

@cjwinsor cjwinsor added modus-accordion bug Something is wrong and needs to be addressed labels Apr 12, 2024
@cjwinsor cjwinsor merged commit 51de759 into main Apr 12, 2024
9 checks passed
@cjwinsor cjwinsor deleted the 2406-accordion-expanded-headerbutton-should-have-a-light-blue-background branch April 12, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed modus-accordion
Projects
None yet
3 participants