Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Group: Label mismatch with radio button #2434

Merged

Conversation

ElishaSamPeterPrabhu
Copy link
Collaborator

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu commented Apr 12, 2024

Description

  • Added for to the label representing the id added to the input from props.id

Fixes: #2433

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

https://deploy-preview-2434--moduswebcomponents.netlify.app/?path=/story/user-inputs-radio-group--medium

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 4071b71
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/661f965244c9a90008cbf872
😎 Deploy Preview https://deploy-preview-2434--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 3 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff self-requested a review April 13, 2024 01:49
@coliff
Copy link
Member

coliff commented Apr 16, 2024

This is better than it was - thanks! However, the ids are not very unique... e.g. id="1" - can we make change them to id="radio-1" instead?

@ElishaSamPeterPrabhu
Copy link
Collaborator Author

This is better than it was - thanks! However, the ids are not very unique... e.g. id="1" - can we make change them to id="radio-1" instead?

Updated ID

@coliff coliff merged commit 911ec58 into main Apr 17, 2024
10 checks passed
@coliff coliff deleted the 2433-radio-group-radio-buttons-label-mismatch-with-radio-button branch April 17, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio Group: Radio button's label mismatch with radio button
3 participants