Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Group: Update docs #2436

Merged

Conversation

ElishaSamPeterPrabhu
Copy link
Collaborator

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu commented Apr 15, 2024

Description

  • Update docs with controls
    aria-label
    disabled
    name
    size
    of radio button

References #2435

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked an issue Apr 15, 2024 that may be closed by this pull request
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 763af32
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/661d020383ed020008190d4f
😎 Deploy Preview https://deploy-preview-2436--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu changed the title Radio button group: Update docs Radio Group: Update docs Apr 15, 2024
@coliff coliff self-requested a review April 15, 2024 13:52
@coliff coliff added the docs label Apr 15, 2024
Copy link
Member

@coliff coliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam - this is great 👍

@coliff coliff merged commit 635bd21 into main Apr 16, 2024
10 checks passed
@coliff coliff deleted the issue-2435/radio-group-canvas-example-should-have-controls branch April 16, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Radio group Canvas example should have controls
3 participants