Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps: Build Stencil Dist Files in Dev Mode #2445

Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Apr 16, 2024

Description

This means that CSS is compiled and added to dist folder in dev mode which means it is hot-reloadable in Storybook serve mode. Makes development much faster!

References #2442

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff linked an issue Apr 16, 2024 that may be closed by this pull request
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit a06674c
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/661f94c544c9a90008cbd93d
😎 Deploy Preview https://deploy-preview-2445--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 4 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff added 1 1 story point devOps Site management, GitHub workflows, etc labels Apr 16, 2024
@coliff coliff changed the title Build Dist Files in Dev Mode DevOps: Build Stencil Dist Files in Dev Mode Apr 16, 2024
@coliff coliff requested a review from cjwinsor April 16, 2024 12:30
This means that CSS is compiled and added to dist folder in dev mode which means it is hot-reloadable in Storybook serve mode. Makes development much faster!
@cjwinsor cjwinsor merged commit 84898e9 into main Apr 18, 2024
9 checks passed
@cjwinsor cjwinsor deleted the 2442-hot-reloading-of-css-changes-not-working-in-storybook branch April 18, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 1 story point devOps Site management, GitHub workflows, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot-reloading of CSS changes not working in Storybook
3 participants