Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: fix issue with tooltip creating a new line when multiple buttons are in a row #2449

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Tooltip: fix issue with tooltip creating a new line when multiple buttons are in a row #2449

merged 1 commit into from
Apr 25, 2024

Conversation

austinoneil
Copy link
Contributor

@austinoneil austinoneil commented Apr 18, 2024 •
edited
Loading

Description

Behavior was because of how modus-tooltip is implemented (i.e. as a div). Using inline-block prevents this behavior.

References #2438

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Manually verify in both Chrome and Firefox

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited
Loading

✅ Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 95c9fba
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/6620b34be0ce870008b24c5b
😎 Deploy Preview https://deploy-preview-2449--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 26 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@austinoneil
Copy link
Contributor Author

austinoneil commented Apr 18, 2024 •
edited by coliff
Loading

Here's my index.html:

<!DOCTYPE html>
<html dir="ltr" lang="en">
  <head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Trimble Modus Web Components</title>

    <script type="module" src="/build/modus-web-components.esm.js"></script>
    <script nomodule src="/build/modus-web-components.js"></script>

    <link rel="stylesheet" href="/build/modus-web-components.css" />

    <!--Manually load Modus font-family-->
    <link rel="preconnect" href="https://fonts.gstatic.com/" crossorigin />
    <link rel="stylesheet" src="https://fonts.googleapis.com/css?family=Open+Sans:300,400,600,700" />
  </head>

  <body data-mwc-theme="dark">
    <modus-tooltip text="Tooltip text...">
      <modus-button><modus-icon name="map"/></modus-button>
    </modus-tooltip>
    <modus-tooltip text="Tooltip text...">
      <modus-button><modus-icon name="map"/></modus-button>
    </modus-tooltip>
    <modus-tooltip text="Tooltip text...">
      <modus-button><modus-icon name="map"/></modus-button>
    </modus-tooltip>
    <modus-tooltip text="Tooltip text...">
      <modus-button><modus-icon name="map"/></modus-button>
    </modus-tooltip>
 </body>
</html>

@coliff coliff requested a review from cjwinsor April 18, 2024 06:32
@coliff coliff changed the title fix issue with tooltip creating a new line when multiple buttons are in a row Tooltip: fix issue with tooltip creating a new line when multiple buttons are in a row Apr 18, 2024
@coliff coliff added the bug Something is wrong and needs to be addressed label Apr 18, 2024
@cjwinsor cjwinsor merged commit 5728b25 into trimble-oss:main Apr 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwinsor cjwinsor cjwinsor approved these changes

@coliff coliff Awaiting requested review from coliff coliff is a code owner

Assignees
No one assigned
Labels
bug Something is wrong and needs to be addressed modus-tooltip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austinoneil @cjwinsor @coliff