Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Fix disabled behavior on dropdown element #2456

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

austinoneil
Copy link
Contributor

@austinoneil austinoneil commented Apr 21, 2024

Description

Fix disabled behavior on dropdown element. Adds disabled to toggle element and prevents actions when disabled.

References #2419

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Manual using existing Storybook implementation, e2e tests

https://deploy-preview-2456--moduswebcomponents.netlify.app/?path=/story/components-dropdown--default&args=disabled:true

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d9e3495
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66248d656e3bcf0008872730
😎 Deploy Preview https://deploy-preview-2456--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff requested review from cjwinsor and coliff April 22, 2024 13:19
@coliff coliff added the bug Something is wrong and needs to be addressed label Apr 22, 2024
Copy link
Member

@coliff coliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thank you! It'd be great to add the CSS pointer-events: none when disabled.

@coliff coliff merged commit d5233b9 into trimble-oss:main Apr 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed modus-dropdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants