-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete: show all items Behavior #2484
Autocomplete: show all items Behavior #2484
Conversation
… option list content
… option list content
@cjwinsor this has already been tested for the following scenarios in this user story: Scenario 1: Validate that the Process Filter shows all available options when focused Scenario 2: Validate that the Process Filter is able to filter based on search criteria via adding characters Scenario 3: Validate that the Process Filter is able to filter based on search criteria via removing characters. An empty again Process filter must show all available options Scenario 4: Validate that the Process Filter clears all characters and show the placeholder text "search processes" when characters are entered but the filter loses focus without a selection Scenario 5: Validate that the Process Filter shows all available options when refocusing on the filter after an option was previously selected. The already selected item item shows with a checkmark on the right and is the second one from the bottom of the list (when able) Scenario 6: Validate that when there are no matches when searching with no previous selection the dropdown will show a “not found” message. Scenario 7: Validate that when there are no matches when searching with a previous selection the dropdown will show a “not found” message. Focusing out will show the previously selected option Scenario 8: Validate that clearing the autocomplete removes the highlighted selection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things I noticed:
A flicker was introduced when picking an item (in my case, I didn't set any props, only set options
) that wasn't there before. The text goes blank, then shows new value.
It now behaves as if show-options-on-focus
is always enabled. It should not show the items on focus until that prop is set to true. There seems to be a previous bug where once there is a selection it opens the autocomplete on focus even when show-options-on-focus
is not set to true
, that isn't correct either.
If I have a value selected, and while focused on the textbox, click the down arrow, it erases the text and the selection. The down arrow should not remove the value/selection.
stencil-workspace/src/components/modus-autocomplete/modus-autocomplete.tsx
Show resolved
Hide resolved
… function, fixing a test after fixing showAllOptionsOnFocus
… function, fixing a test after fixing showAllOptionsOnFocus
… function, fixing a test after fixing showAllOptionsOnFocus
stencil-workspace/src/components/modus-autocomplete/modus-autocomplete.e2e.ts
Fixed
Show fixed
Hide fixed
Validated that the autocomplete complies with the following scenarios Scenario 1: Validate that the Process Filter shows all available options when focused Scenario 2: Validate that the Process Filter is able to filter based on search criteria via adding characters Scenario 3: Validate that the Process Filter is able to filter based on search criteria via removing characters. An empty again Process filter must show all available options Scenario 4: Validate that the Process Filter shows all available options when refocusing on the filter after an option was previously selected. Scenario 5: Validate that when there are no matches when searching with no previous selection the dropdown will show a “not found” message. Scenario 6: Validate that when there are no matches when searching with a previous selection the dropdown will show a “not found” message. Scenario 7: Validate that clearing the autocomplete removes the highlighted selection. |
Description
References #2282 #2567
This PR without knowing also fixes the issue:: #2567
Type of change
How Has This Been Tested?
Checklist