Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Tree: Updated Tree View Item #2485

Conversation

prashanthr6383
Copy link
Collaborator

@prashanthr6383 prashanthr6383 commented Apr 26, 2024

Description

  • modified state of width to be important

References
Fixes #1596

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d07097
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/663dc5df61e97b0008a1182d
😎 Deploy Preview https://deploy-preview-2485--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjwinsor
Copy link
Contributor

cjwinsor commented May 7, 2024

After discuss with team:

  • Make sure space isn't allocated for drag handler unless its show. Currently it always includes the the drag element but doesn't show the icon until its needed. That space is pushing the expand arrow away too much from the left side
  • Make sure to always reserve the space for the selection blue bar indicator, which is currently .3rem in width
    image
    image
    image
    image
    image

@coliff coliff changed the title Content tree : Updated Tree View Item Content Tree: Updated Tree View Item May 8, 2024
@prashanthr6383
Copy link
Collaborator Author

After discuss with team:

  • Make sure space isn't allocated for drag handler unless its show. Currently it always includes the the drag element but doesn't show the icon until its needed. That space is pushing the expand arrow away too much from the left side
  • Make sure to always reserve the space for the selection blue bar indicator, which is currently .3rem in width
    image
    image
    image
    image
    image

Hi @cjwinsor requested changes are done. kindly check and approve

@cjwinsor
Copy link
Contributor

cjwinsor commented May 9, 2024

@prashanthr6383 Can you undo my request to remove the drag indicator when not in use? Since each item has its own draggableItem prop, it can cause bad alignment if one item is draggable and the next isn't. We'll need to revisit how we handle dragging in a later ticket.

@prashanthr6383
Copy link
Collaborator Author

@prashanthr6383 Can you undo my request to remove the drag indicator when not in use? Since each item has its own draggableItem prop, it can cause bad alignment if one item is draggable and the next isn't. We'll need to revisit how we handle dragging in a later ticket.

Hi @cjwinsor reverted back the drag icon to be hidden.

@cjwinsor cjwinsor merged commit 413d422 into trimble-oss:main May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modus Content tree - No enough space between the tree view indicator line and drag and drop icon
2 participants