Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Autocomplete Form Control Input colors #2562

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 3, 2024

Description

  • Add 4px border radius to input container
  • Add focus-within 2px blue border
  • Change label to font-weight: 700 and add bottom-margin

References #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

https://deploy-preview-2562--moduswebcomponents.netlify.app/?path=/docs/user-inputs-autocomplete--default

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit c487983
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/665ddd49ea0bbd00085be08e
😎 Deploy Preview https://deploy-preview-2562--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 24 (🔴 down 3 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff requested a review from cjwinsor June 3, 2024 15:08
@coliff coliff force-pushed the dev/coliff/fix-autocomplete-form-control-colors branch from a208adc to c487983 Compare June 3, 2024 15:12
@coliff coliff requested a review from egunther39 June 3, 2024 15:13
- Add 4px border radius to input container
- Add focus-within 2px blue border
- Change label to font-weight: 700 and add bottom-margin
@coliff coliff merged commit e68ea6c into main Jun 3, 2024
10 checks passed
@coliff coliff deleted the dev/coliff/fix-autocomplete-form-control-colors branch June 3, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants