Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea: Input Style Fixes #2587

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Textarea: Input Style Fixes #2587

merged 1 commit into from
Jun 14, 2024

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 12, 2024

Description

  • Allows the textarea to be vertically resized
  • Adds visible 2px border on focus and valid/invalid states
  • Removes the clearable example (seemed unnecessary and looked bad)
  • Removed hard-coded height of the inputs

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Locally with Edge v125

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for moduswebcomponents canceled.

Name Link
🔨 Latest commit 5617659
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/6669bfb467f2c900095aa08d

@coliff coliff force-pushed the dev/coliff/textarea-style-fixes branch from 2d415a0 to 5617659 Compare June 12, 2024 15:33
@coliff coliff requested a review from cjwinsor June 12, 2024 15:33
@coliff coliff added the bug Something is wrong and needs to be addressed label Jun 12, 2024
- Allows the textarea to be vertically resized
- Adds visible 2px border on focus and valid/invalid states
- Removes the clearable example (seemed unnecessary and looked bad)
- Removed hard-coded height of the inputs
@cjwinsor cjwinsor merged commit 5f64e71 into main Jun 14, 2024
11 checks passed
@cjwinsor cjwinsor deleted the dev/coliff/textarea-style-fixes branch June 14, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants