Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows Forced-Colors High Contrast Theme Support #2601

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 17, 2024

Description

Improves Windows Forced-Colors High Contrast Theme Support

Fixes: #2596

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Tested with Edge and Chrome on Windows 11 Pro by using the forced-colors: active option in Dev Tools - both light and dark mode.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff linked an issue Jun 17, 2024 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit b166552
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66700b0dfc09dd0008346fd5
😎 Deploy Preview https://deploy-preview-2601--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 24 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff force-pushed the 2595-forced-colors-mode-issues branch 2 times, most recently from d5e5473 to b166552 Compare June 17, 2024 10:08
@coliff coliff merged commit ed2c2f8 into main Jun 17, 2024
11 checks passed
@coliff coliff deleted the 2595-forced-colors-mode-issues branch June 17, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete: Improve handling for when to open lists by default Forced-Colors Mode Issues
1 participant