Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea: readonly state CSS fix #2631

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 21, 2024

Description

  • Add readonly state CSS
  • Remove unused icons CSS

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Preview:
https://deploy-preview-2631--moduswebcomponents.netlify.app/?path=/story/user-inputs-textarea-input--default&args=readOnly:true

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

- Add readonly state CSS
- Remove unused icons CSS
@coliff coliff linked an issue Jun 21, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit cd30640
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66752bb50235b90008830149
😎 Deploy Preview https://deploy-preview-2631--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 23 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff changed the title Textarea CSS fixes Textarea: readonly state CSS fix Jun 21, 2024
@coliff coliff added the bug Something is wrong and needs to be addressed label Jun 21, 2024
@coliff coliff merged commit 0520244 into main Jun 24, 2024
10 checks passed
@coliff coliff deleted the 2630-textarea-read-only-state-css-isnt-available branch June 24, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textarea: read-only state CSS isn't available
1 participant