Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Return whole selected object from an editable cell #2668

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sorina-ocheana
Copy link
Contributor

@sorina-ocheana sorina-ocheana commented Jul 2, 2024

Description

When changing the value on an editable cell, type select, and it returns the whole selected object

References #2667

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bfcb0f0
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/6683b6cbc64e55000799a2cb
😎 Deploy Preview https://deploy-preview-2668--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 23 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@prashanth-offcl prashanth-offcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorina-ocheana Marking this as a breaking change, also in storybook the select column displays Object after changing it.

@prashanth-offcl prashanth-offcl added the breaking-change Changes that can potentially impact the applications already using it label Sep 11, 2024
@prashanth-offcl prashanth-offcl marked this pull request as draft September 11, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that can potentially impact the applications already using it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants