-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete: Multi select chips render issue #2681
Merged
prashanth-offcl
merged 9 commits into
main
from
2529---Multi-select-render-issue-in-autocomplete
Aug 7, 2024
Merged
Autocomplete: Multi select chips render issue #2681
prashanth-offcl
merged 9 commits into
main
from
2529---Multi-select-render-issue-in-autocomplete
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moduswebcomponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
prashanthr6383
changed the title
2529 - autocomplete string to chip conversion on initilization
Autocomplete : Multi select render issue
Jul 8, 2024
prashanthr6383
changed the title
Autocomplete : Multi select render issue
Autocomplete: Multi select chips render issue
Jul 8, 2024
@cjwinsor I have added the test cases now and it is ready for review |
prashanth-offcl
approved these changes
Aug 7, 2024
prashanth-offcl
deleted the
2529---Multi-select-render-issue-in-autocomplete
branch
August 7, 2024 08:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Value
Prop now accepts bothsingle-select-type = string
multiple-select-type = string[]
The default value can be assigned for multi-select, provided the value is an array.
e.g., ['Apple', 'Orange']
valueChange
event emitter type changed to string | string[].Fixes #2529, Fixes #2528
Type of change
How Has This Been Tested?
Checklist