Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts: Update Styles #2724

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Alerts: Update Styles #2724

merged 2 commits into from
Jul 24, 2024

Conversation

coliff
Copy link
Member

@coliff coliff commented Jul 24, 2024

Description

Fixes: #2626

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Locally with Edge on Windows 11

https://deploy-preview-2724--moduswebcomponents.netlify.app/?path=/docs/components-alert--default#alert

image

image

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff linked an issue Jul 24, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit c663421
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66a0d213556b830008eb3075
😎 Deploy Preview https://deploy-preview-2724--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🟢 up 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff changed the title Update Modus Alerts Alerts: Update Styles Jul 24, 2024
@coliff coliff merged commit 30ef4cd into main Jul 24, 2024
11 checks passed
@coliff coliff deleted the 2626-alerts-updated-to-match-figma branch July 24, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerts Updated to Match Figma
2 participants