Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Hide Vertical borders of cell #2767

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

ElishaSamPeterPrabhu
Copy link
Collaborator

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu commented Aug 7, 2024

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked an issue Aug 7, 2024 that may be closed by this pull request
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 08c1cfb
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66b494072b3bca0008026634
😎 Deploy Preview https://deploy-preview-2767--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 24 (🔴 down 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu force-pushed the 2675-borderless-table-should-have-bottom-line branch from 4fcd8f8 to 138a96e Compare August 7, 2024 09:27
@prashanth-offcl
Copy link
Collaborator

@ElishaSamPeterPrabhu Looks good to me, I can merge this PR once you fix the typo 'cellVertcalBorderless ' in the storybook changes

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu force-pushed the 2675-borderless-table-should-have-bottom-line branch from 138a96e to fee3fc6 Compare August 8, 2024 07:32
@prashanth-offcl prashanth-offcl merged commit 9fa7d07 into main Aug 8, 2024
11 checks passed
@prashanth-offcl prashanth-offcl deleted the 2675-borderless-table-should-have-bottom-line branch August 8, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Borderless table should have bottom line
2 participants