-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table: Hide Vertical borders of cell #2767
Merged
prashanth-offcl
merged 7 commits into
main
from
2675-borderless-table-should-have-bottom-line
Aug 8, 2024
Merged
Table: Hide Vertical borders of cell #2767
prashanth-offcl
merged 7 commits into
main
from
2675-borderless-table-should-have-bottom-line
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moduswebcomponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ElishaSamPeterPrabhu
force-pushed
the
2675-borderless-table-should-have-bottom-line
branch
from
August 7, 2024 09:27
4fcd8f8
to
138a96e
Compare
@ElishaSamPeterPrabhu Looks good to me, I can merge this PR once you fix the typo 'cellVertcalBorderless ' in the storybook changes |
ElishaSamPeterPrabhu
force-pushed
the
2675-borderless-table-should-have-bottom-line
branch
from
August 8, 2024 07:32
138a96e
to
fee3fc6
Compare
…://github.com/trimble-oss/modus-web-components into 2675-borderless-table-should-have-bottom-line
prashanth-offcl
approved these changes
Aug 8, 2024
prashanth-offcl
deleted the
2675-borderless-table-should-have-bottom-line
branch
August 8, 2024 09:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cellVertcalBorderless
to toggle between the visibility of cell's vertical bordersReferences
Fixes Borderless table should have bottom line #2675
Type of change
How Has This Been Tested?
Checklist