Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker: Fix date picker event handling to account for shadowDOM #2838

Conversation

raymondboswel
Copy link
Contributor

Description

Date picker event handling did not account for use within shadowDOM. Updated to use composedPath, which works across shadowDOM boundary.

References #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

I reproduced the issue here: https://github.com/raymondboswel/modus-datepicker-reproduction.

I then implemented the fix in a local copy of modus-web-components and installed the local version in the
reproduction project, verifying the fix. I also ran the modus-web-components test suite with no failures.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Date picker event handling did not account for use within shadowDOM.
Updated to use composedPath, which works across shadowDOM bonudary.
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 539b73e
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66d78abb16426c0008cb6e66
😎 Deploy Preview https://deploy-preview-2838--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🟢 up 3 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@prashanth-offcl prashanth-offcl merged commit 423e466 into trimble-oss:main Sep 4, 2024
10 checks passed
@prashanth-offcl prashanth-offcl added the bug Something is wrong and needs to be addressed label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants