Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/azure cert deploy #1132

Merged
merged 12 commits into from
Jul 3, 2024
Merged

Feature/azure cert deploy #1132

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4e40945
Begin work on certPath support
isaac-boaz-trimble Jul 2, 2024
810a9ee
Init new trccertmgmtbase
isaac-boaz-trimble Jul 2, 2024
db54fff
Copy from trcapimgmt
isaac-boaz-trimble Jul 2, 2024
42bdb97
Add base impl to ues certmgmt, use propery cert api
isaac-boaz-trimble Jul 3, 2024
e0bd26b
Support cert password being stored in vault
isaac-boaz-trimble Jul 3, 2024
4df9376
Fix 500 errors
isaac-boaz-trimble Jul 3, 2024
36965c3
Add existence checks, reomve memory protections
isaac-boaz-trimble Jul 3, 2024
2b28dfc
One-line if-return
isaac-boaz-trimble Jul 3, 2024
36028b7
Fix exists parity
isaac-boaz-trimble Jul 3, 2024
b990c88
Convert Fatal -> Print, scrub some output
isaac-boaz-trimble Jul 3, 2024
249339c
Adding APIMConfig template
KarnveerSGill Jul 3, 2024
7837e81
Update failed request error logging
isaac-boaz-trimble Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions atrium/vestibulum/trcdb/trccertmgmtbase/trccertmgmtbase.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ import (
"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
"github.com/Azure/azure-sdk-for-go/sdk/azidentity"
"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/apimanagement/armapimanagement/v2"
"github.com/trimble-oss/tierceron/buildopts/memonly"
"github.com/trimble-oss/tierceron/buildopts/memprotectopts"
eUtils "github.com/trimble-oss/tierceron/pkg/utils"
"github.com/trimble-oss/tierceron/pkg/vaulthelper/kv"
)
Expand All @@ -23,10 +21,6 @@ func CommonMain(certPathPtr *string, driverConfig *eUtils.DriverConfig, mod *kv.
return errors.New("certPath flag is empty, expected path to cert")
}

if memonly.IsMemonly() {
memprotectopts.MemProtectInit(nil)
}

certBytes, err := os.ReadFile(*certPathPtr)
if err != nil {
return err
Expand Down Expand Up @@ -61,11 +55,19 @@ func CommonMain(certPathPtr *string, driverConfig *eUtils.DriverConfig, mod *kv.
return err
}

resourceGroupName := apimConfigMap["RESOURCE_GROUP_NAME"]
serviceName := apimConfigMap["SERVICE_NAME"]
resourceGroupName, exists := apimConfigMap["RESOURCE_GROUP_NAME"]
isaac-boaz-trimble marked this conversation as resolved.
Show resolved Hide resolved
if !exists {
return errors.New("RESOURCE_GROUP_NAME is not populated in apimConfigMap")
}

serviceName, exists := apimConfigMap["SERVICE_NAME"]
isaac-boaz-trimble marked this conversation as resolved.
Show resolved Hide resolved
if !exists {
return errors.New("SERVICE_NAME is not populated in apimConfigMap")
}

certificateId := time.Now().UTC().Format(strings.ReplaceAll(time.RFC3339, ":", "-"))

etag := "*" //Wildcard match on eTag, otherwise it doesn't match from command above.
etag := "*"

_, err = clientFactory.NewCertificateClient().CreateOrUpdate(ctx, resourceGroupName, serviceName, certificateId, armapimanagement.CertificateCreateOrUpdateParameters{
Properties: &armapimanagement.CertificateCreateOrUpdateProperties{
Expand All @@ -79,6 +81,6 @@ func CommonMain(certPathPtr *string, driverConfig *eUtils.DriverConfig, mod *kv.
return err
}

fmt.Println("Success!")
fmt.Printf("Certificate %v successfully deployed\n", certificateId)
return nil
}