Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various codeql fixes. #865

Merged
merged 192 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from 187 commits
Commits
Show all changes
192 commits
Select commit Hold shift + click to select a range
948671a
Making more util trcsub for common.
joel-rieke Nov 3, 2023
8ed2020
Apply state changes.
joel-rieke Nov 3, 2023
d9883a1
Checking in progress.
joel-rieke Nov 3, 2023
e9d07c7
Reverting some hardcodings.
joel-rieke Nov 3, 2023
5a6838c
Adding some robustness handling and changes to initial states.
joel-rieke Nov 6, 2023
ca9a4cc
More state updates for windows side.
joel-rieke Nov 6, 2023
9919577
Allow for definition of service.
joel-rieke Nov 7, 2023
610c815
Adding Refresh syncMode (#775)
KarnveerSGill Nov 7, 2023
d325dbb
Merge branch 'main' into develop
joel-rieke Nov 8, 2023
89d6fc9
Fix missing import.
joel-rieke Nov 8, 2023
62d5da3
Merge branch 'main' into develop
joel-rieke Nov 9, 2023
4ffa719
Better support for server cert.
joel-rieke Nov 9, 2023
456bf30
Update to go 1.21.4
joel-rieke Nov 9, 2023
db992e3
Merge branch 'main' into develop
joel-rieke Nov 9, 2023
3836471
More robust state handling.
joel-rieke Nov 9, 2023
8ad2736
Merge branch 'main' into develop
joel-rieke Nov 9, 2023
423f9e9
Prevent premature exits.
joel-rieke Nov 9, 2023
b0bfecd
Switch to ranging over channel.
joel-rieke Nov 9, 2023
5f0c272
Merge branch 'main' into develop
joel-rieke Nov 9, 2023
136bc9f
Cleanup output for deployments.
joel-rieke Nov 9, 2023
9ee1942
Add deployment for TrcDeploy
joel-rieke Nov 9, 2023
069266b
Adding channel unblocker
KarnveerSGill Nov 10, 2023
1a2e189
Adding back timer
KarnveerSGill Nov 10, 2023
06f29ef
Add template for agent deploys.
joel-rieke Nov 10, 2023
3ac49ee
Update to latest hat.
joel-rieke Nov 10, 2023
7f27ca0
Fixing go.mod
joel-rieke Nov 10, 2023
7b32f04
Merge branch 'main' into develop
joel-rieke Nov 10, 2023
d888731
Merge branch 'releases/plugin/1.0.0' into develop
joel-rieke Nov 10, 2023
047801f
Merge branch 'main' into develop
joel-rieke Nov 10, 2023
7576668
Cleanup config and certify to handle errors more gracefully for bette…
joel-rieke Nov 10, 2023
25aecf4
Certify exit with error code.
joel-rieke Nov 10, 2023
b34c145
Fixing some crashing.
joel-rieke Nov 10, 2023
b88b154
Let this happen async.
joel-rieke Nov 10, 2023
0950c85
Adding some more commands.
joel-rieke Nov 11, 2023
3fd2ec2
Select more suitable param name.
joel-rieke Nov 11, 2023
fbcbc0a
Merge branch 'main' into develop
joel-rieke Nov 12, 2023
35a8e56
Add some error handling with early exit.
joel-rieke Nov 12, 2023
0b129f7
Merge branch 'main' into develop
joel-rieke Nov 12, 2023
14307d0
Make deployments re-runnable.
joel-rieke Nov 12, 2023
f0c91cf
Set timer for each run. Make CtlMessage a buffered channel.
joel-rieke Nov 12, 2023
dc2a4f2
Merge branch 'main' into develop
joel-rieke Nov 12, 2023
ec57f5a
Couple more fixes for multi-deploy.
joel-rieke Nov 12, 2023
c4fb99e
Small spelling correction.
joel-rieke Nov 12, 2023
7191b40
Get everything at least running... Output to correct directory not ye…
joel-rieke Nov 12, 2023
c3c8198
A little more cleanup.
joel-rieke Nov 12, 2023
564a5f5
Add support for projectservice.
joel-rieke Nov 13, 2023
5ccc616
Add read support for projectservice.
joel-rieke Nov 13, 2023
4592101
Fix missing import.
joel-rieke Nov 13, 2023
521bb28
Fixing couple bugs and log cleanup.
joel-rieke Nov 13, 2023
014d312
Revert breaking change.
joel-rieke Nov 13, 2023
5422bfb
Merge branch 'main' into develop
joel-rieke Nov 13, 2023
4a0e3c3
Revert breaking change.
joel-rieke Nov 13, 2023
6523cd4
Provide appropriate inputs. Handle bad inputs.
joel-rieke Nov 13, 2023
f0fc3b3
Merge branch 'main' into develop
joel-rieke Nov 13, 2023
bb8ece9
Fix hacky logic.
joel-rieke Nov 13, 2023
0b9a3d3
Merge branch 'main' into develop
joel-rieke Nov 13, 2023
87b4779
Merge branch 'main' into develop
joel-rieke Nov 13, 2023
397a910
Merge branch 'main' into develop
joel-rieke Nov 13, 2023
2bea7d8
Merge branch 'main' into develop
joel-rieke Nov 13, 2023
a3866f1
Fix so trcsh works with empty directory.
joel-rieke Nov 13, 2023
c179849
Merge branch 'main' into develop
joel-rieke Nov 14, 2023
f7cfa35
Instrument interruptibility.
joel-rieke Nov 14, 2023
a600122
Adjust wait times.
joel-rieke Nov 14, 2023
838d8fb
Adding window utility function to make life easier.
joel-rieke Nov 14, 2023
d2c7fe3
Fix downloading.
joel-rieke Nov 14, 2023
8ad2ade
Better error handling of keystore creation.
joel-rieke Nov 14, 2023
d3b1a80
Honor enddir and startdir when provided.
joel-rieke Nov 14, 2023
99f6ca1
Merge branch 'main' into develop
joel-rieke Nov 14, 2023
c76bfc5
Provide more concise override options.
joel-rieke Nov 14, 2023
70ae2a4
Merge branch 'main' into develop
joel-rieke Nov 14, 2023
6ad50a7
Prevent double completion.
joel-rieke Nov 14, 2023
46dbac3
Update version for confirmation.
joel-rieke Nov 14, 2023
715b2d9
Removing a deadlock.
joel-rieke Nov 14, 2023
7d4b19e
Increase timeout.
joel-rieke Nov 15, 2023
d1bea2f
Adding some retries.
joel-rieke Nov 15, 2023
167ac2b
Make re-entrant safe.
joel-rieke Nov 15, 2023
24d8e07
Merge branch 'main' into develop
joel-rieke Nov 15, 2023
3c4e80a
Merge branch 'main' into develop
joel-rieke Nov 15, 2023
247e53a
Make this more interruptible.
joel-rieke Nov 15, 2023
cb58c25
Fixing flags and usage.
joel-rieke Nov 15, 2023
24188f2
Changes achieve the following:
joel-rieke Nov 15, 2023
cec3a4c
Update trcx to use flagset as well.
joel-rieke Nov 15, 2023
b64bc3f
Update xp to provide proper args as well.
joel-rieke Nov 15, 2023
00320a8
Fixing improper references...
joel-rieke Nov 15, 2023
b08d6f4
Expose diff flag for trcctl.
joel-rieke Nov 15, 2023
fd495bb
Fixing some brokenness.
joel-rieke Nov 15, 2023
c198d99
Timeout wasn't issue. Reverting change.
joel-rieke Nov 15, 2023
8f52b2d
Merge branch 'main' into develop
joel-rieke Nov 15, 2023
f1ece65
Concurrency fix:
joel-rieke Nov 15, 2023
b74c98c
Merge branch 'main' into develop
joel-rieke Nov 15, 2023
52e2ca7
Merge branch 'main' into develop
joel-rieke Nov 15, 2023
399c912
Merge branch 'main' into develop
joel-rieke Nov 15, 2023
bf1ee65
Merge branch 'main' into develop
joel-rieke Nov 15, 2023
6fb020a
Merge branch 'main' into develop
joel-rieke Nov 15, 2023
708c46a
Merge branch 'main' into develop
joel-rieke Nov 16, 2023
981a7f2
Merge branch 'main' into develop
joel-rieke Nov 16, 2023
1edfcb2
Merge branch 'main' into develop
joel-rieke Nov 16, 2023
3b08902
Merge branch 'main' into develop
joel-rieke Nov 16, 2023
4691405
Update wording for any.
joel-rieke Nov 16, 2023
bf21581
Feathering only in lower environments.
joel-rieke Nov 16, 2023
1bbdaa0
A little cleanup and a little error handling.
joel-rieke Nov 16, 2023
0168571
Fix env selection problem in trcsh.
joel-rieke Nov 16, 2023
ebc09c5
Merge branch 'main' into develop
joel-rieke Nov 16, 2023
87e37ed
Merge branch 'main' into develop
joel-rieke Nov 16, 2023
2d7933e
Fix cert validation for rqa and auto.
joel-rieke Nov 20, 2023
958f57e
Add support for subpath deployments on codedeploy.
joel-rieke Nov 20, 2023
6c52cb8
This should return an error, not exit.
joel-rieke Nov 21, 2023
2d07c13
Only exit on failure for command driven.
joel-rieke Nov 21, 2023
2982747
Merge branch 'main' into develop
joel-rieke Nov 21, 2023
bb7889c
Better handling of acceptable errors.
joel-rieke Nov 21, 2023
d516d2a
Merge branch 'main' into develop
joel-rieke Nov 21, 2023
4346371
Concurrency improvements. (#823)
joel-rieke Nov 22, 2023
4d4c992
Merge branch 'main' into develop
joel-rieke Nov 22, 2023
8a6e105
Fixing a couple logic bugs.
joel-rieke Nov 22, 2023
e607cff
Update to latest.
joel-rieke Nov 23, 2023
090b5e3
Fix HTTP/2
joel-rieke Nov 23, 2023
e6318ac
Fix HTTP/2
joel-rieke Nov 23, 2023
333f324
Fix swift-nio-http2
joel-rieke Nov 23, 2023
c44d37c
Update for consistency
joel-rieke Nov 23, 2023
099c05a
More security updates.
joel-rieke Nov 23, 2023
e16aaa3
Update to latest.
joel-rieke Nov 27, 2023
d424bd6
Using more concise session identifier.
joel-rieke Nov 27, 2023
520fb83
Merge branch 'main' into develop
joel-rieke Nov 28, 2023
5cec4c1
Log errors when it makes sense to.
joel-rieke Nov 28, 2023
194b865
Small changes to provide better error handling.
joel-rieke Nov 28, 2023
8c23739
Merge branch 'main' into develop
joel-rieke Nov 28, 2023
2d3653e
Fix for trcsh state processing and windows.
joel-rieke Nov 28, 2023
605a47d
A little cleanup.
joel-rieke Nov 29, 2023
b89f171
Merge branch 'main' into develop
joel-rieke Nov 29, 2023
aa3dcf3
Merge branch 'main' into develop
joel-rieke Nov 29, 2023
1c518ec
Merge branch 'main' into develop
joel-rieke Nov 30, 2023
eefd8f7
Clean up token selection.
joel-rieke Nov 30, 2023
287a5dd
Adding error messaging for incorrect project setup.
joel-rieke Nov 30, 2023
949dc8d
Reduce logging.
joel-rieke Nov 30, 2023
3beffc5
Tweak wording.
joel-rieke Nov 30, 2023
41925ce
Merge branch 'main' into develop
joel-rieke Nov 30, 2023
d65fb6f
Funnel errors upstream better.
joel-rieke Nov 30, 2023
676f7f5
Make pluginName come from deployer.
joel-rieke Dec 1, 2023
58daff9
More assurance that tomcat goes down before copying.
joel-rieke Dec 1, 2023
6eeb923
Fix problem with certifying.
joel-rieke Dec 1, 2023
57dd765
Merge branch 'main' into develop
joel-rieke Dec 1, 2023
77da665
Update to latest.
joel-rieke Dec 1, 2023
8136753
Adding some assurances.
joel-rieke Dec 1, 2023
2d81e7e
Add clarifying comment.
joel-rieke Dec 1, 2023
7bf960e
Merge branch 'main' into develop
joel-rieke Dec 1, 2023
ab9625d
Merge branch 'main' into develop
joel-rieke Dec 1, 2023
2f9507e
Merge branch 'main' into develop
joel-rieke Dec 2, 2023
7bfb03d
Some logging cleanup
joel-rieke Dec 2, 2023
d943151
Fixing break on windows.
joel-rieke Dec 2, 2023
5713e7f
Add more robust support for servicesWanted and filter.
joel-rieke Dec 3, 2023
be5e46b
Deployments should match a deployment run. Always load deployment du…
joel-rieke Dec 4, 2023
5ea6885
Merge branch 'main' into develop
joel-rieke Dec 4, 2023
8ac7851
Merge branch 'main' into develop
joel-rieke Dec 4, 2023
3566f60
Provide service name always if defined.
joel-rieke Dec 5, 2023
d0f255f
Merge branch 'main' into develop
joel-rieke Dec 5, 2023
1b76eb9
Switch to something compatible with nssm
joel-rieke Dec 5, 2023
1d2ff02
Merge branch 'main' into develop
joel-rieke Dec 5, 2023
13ede7e
Go to combination of net stop, taskkill, and sc start.
joel-rieke Dec 5, 2023
5056113
Merge branch 'main' into develop
joel-rieke Dec 5, 2023
26c7d13
Some mod cleanup.
joel-rieke Dec 6, 2023
1dcdb71
Updating to go 1.21.5
joel-rieke Dec 6, 2023
6b3131f
Merge branch 'main' into develop
joel-rieke Dec 6, 2023
490e1d6
Removing log lines
KarnveerSGill Dec 6, 2023
a772ccb
Fixing extra bracket
KarnveerSGill Dec 6, 2023
f25876f
Merge fix
KarnveerSGill Dec 6, 2023
2f434a4
Fixing token request
KarnveerSGill Dec 6, 2023
26fc868
Merge branch 'main' into develop
joel-rieke Dec 6, 2023
c40dee4
Adding support in trcshell for environments like dev-1.
joel-rieke Dec 7, 2023
0774962
Provide env overrides.
joel-rieke Dec 7, 2023
a7b0193
Merge branch 'main' into develop
joel-rieke Dec 7, 2023
fb47f8c
Support plugin config loading even when utilizing custom environments.
joel-rieke Dec 8, 2023
e648daa
Merge branch 'main' into develop
joel-rieke Dec 8, 2023
2bec44c
Merge branch 'main' into develop
joel-rieke Dec 8, 2023
4f8afee
Create SECURITY.md
joel-rieke Dec 8, 2023
557a053
Create LICENSE
joel-rieke Dec 8, 2023
a9e6c92
Delete LICENSE.txt
joel-rieke Dec 8, 2023
506bc7e
Attempting to fix serialization
KarnveerSGill Dec 8, 2023
dc1ad2d
Updating channel length check
KarnveerSGill Dec 8, 2023
33e82ee
Merge branch 'main' into develop
joel-rieke Dec 8, 2023
5a48873
Merge branch 'main' into develop
joel-rieke Dec 9, 2023
cd01acc
Fix locking issue.
joel-rieke Dec 11, 2023
a515aa9
Roll back since not needed anymore.
joel-rieke Dec 12, 2023
c2152c7
Update to more concurrent safe go-mysql
joel-rieke Dec 12, 2023
295c3a3
Update to latest go-mysql-server build.
joel-rieke Dec 12, 2023
c321e54
Merge branch 'main' into develop
joel-rieke Dec 12, 2023
a1231ff
Adding bounds check.
joel-rieke Dec 13, 2023
ffbbba0
Add actual bounds checking.
joel-rieke Dec 13, 2023
aeb113c
Bounds check totalKeyShard
joel-rieke Dec 13, 2023
9112f37
Disallow complex path navigation.
joel-rieke Dec 13, 2023
cc00799
Add log sanitizing.
joel-rieke Dec 13, 2023
aa4c697
More sanitization.
joel-rieke Dec 13, 2023
cb92db8
Directly applying recommendation from dependabot
joel-rieke Dec 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions trcinitbase/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"flag"
"fmt"
"log"
"math"
"os"
"path/filepath"
"strconv"
Expand Down Expand Up @@ -273,11 +274,12 @@
if err != nil {
fmt.Println("Unable to parse totalKeyShard into int")
}
unsealShardPtr, err := strconv.ParseUint(*unsealShardPtr, 10, 32)
if err != nil {
fmt.Println("Unable to parse unsealShardPtr into int")
keyThreshold, err := strconv.ParseUint(*unsealShardPtr, 10, 32)
if err != nil || keyThreshold > math.MaxInt {
fmt.Println("Unable to parse keyThreshold into int")
os.Exit(-1)
}
keyToken, err := v.InitVault(int(totalKeyShard), int(unsealShardPtr))
keyToken, err := v.InitVault(int(totalKeyShard), int(keyThreshold))
Fixed Show fixed Hide fixed
eUtils.LogErrorObject(config, err, true)
v.SetToken(keyToken.Token)
v.SetShards(keyToken.Keys)
Expand Down
10 changes: 8 additions & 2 deletions utils/diffUtil.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"bytes"
"fmt"
"log"
"math"
"net/url"
"sort"
"strconv"
Expand Down Expand Up @@ -317,8 +318,13 @@ func VersionHelper(versionData map[string]interface{}, templateOrValues bool, va

keys := make([]int, 0, len(versionData))
for versionNumber := range versionData {
versionNo, _ := strconv.ParseInt(versionNumber, 10, 64)
keys = append(keys, int(versionNo))
versionNo, err := strconv.ParseInt(versionNumber, 10, 64)
if err == nil && versionNo <= math.MaxInt {
keys = append(keys, int(versionNo))
Fixed Show fixed Hide fixed
} else {
fmt.Printf("Version limit exceeded: %s\n", versionNumber)
return
}
}
sort.Ints(keys)
for _, key := range keys {
Expand Down
Loading