-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support service annotations #134
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Submitted the CLA. Waiting for someone to check it |
@cla-bot check |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
The cla-bot has been summoned, and re-checked this pull request! |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Would be awesome to have this merged |
@p5 please rebase, and I'll review once the new tests pass in the CI. |
Enables the user to add annotations for the service resource so it can be integrated with load balancers and other operators. Signed-off-by: Robert Sturla <robertsturla@outlook.com>
9e633b9
to
bc12506
Compare
Enables the user to add annotations for the service resource so it can be integrated with load balancers and others.
This is a similar PR to #54 and aims to resolve the long-standing issue trinodb/trino#13085, however as the PR hasn't had any progress in almost a year, trying to push through separately.