Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service annotations #134

Merged
merged 1 commit into from
May 30, 2024

Conversation

p5
Copy link
Contributor

@p5 p5 commented Feb 15, 2024

Enables the user to add annotations for the service resource so it can be integrated with load balancers and others.

This is a similar PR to #54 and aims to resolve the long-standing issue trinodb/trino#13085, however as the PR hasn't had any progress in almost a year, trying to push through separately.

Copy link

cla-bot bot commented Feb 15, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@p5
Copy link
Contributor Author

p5 commented Feb 15, 2024

Submitted the CLA. Waiting for someone to check it

@p5
Copy link
Contributor Author

p5 commented Mar 3, 2024

@cla-bot check

Copy link

cla-bot bot commented Mar 3, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Mar 3, 2024

The cla-bot has been summoned, and re-checked this pull request!

@p5
Copy link
Contributor Author

p5 commented Mar 5, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Mar 5, 2024
Copy link

cla-bot bot commented Mar 5, 2024

The cla-bot has been summoned, and re-checked this pull request!

@ArnArm
Copy link

ArnArm commented Apr 24, 2024

Would be awesome to have this merged

@nineinchnick
Copy link
Member

@p5 please rebase, and I'll review once the new tests pass in the CI.

Enables the user to add annotations for the service resource so it can
be integrated with load balancers and other operators.

Signed-off-by: Robert Sturla <robertsturla@outlook.com>
@nineinchnick nineinchnick force-pushed the service-resource-annotations branch from 9e633b9 to bc12506 Compare May 30, 2024 09:55
@nineinchnick nineinchnick merged commit 2ace482 into trinodb:main May 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants